ENH: Use circular weakref to delay copy in setitem #50902
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jorisvandenbossche @phofl for feedback. |
| @@ -4043,12 +4044,12 @@ def _iset_item_mgr( | |||
| self._mgr.iset(loc, value, inplace=inplace) | |||
| self._clear_item_cache() | |||
|
|
|||
| def _set_item_mgr(self, key, value: ArrayLike) -> None: | |||
| def _set_item_mgr(self, key, value: ArrayLike, refs=[]) -> None: | |||
There was a problem hiding this comment.
can we avoid a mutable default
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.This PR uses a circular weakref between the added block in the DataFrame and the original block from the Series, when doing setitem in a DataFrame with a Series (haven't fixed other cases yet, wanted to get feedback on whether I'm on the right track).
With this way, whoever modifies the data first will have to copy the data, and we can delay the copy in
__setitem__.